Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds multipart copy support #106

Closed
wants to merge 3 commits into from
Closed

Adds multipart copy support #106

wants to merge 3 commits into from

Conversation

kerryjj
Copy link

@kerryjj kerryjj commented Apr 10, 2021

This PR sends the required upload_id and part_number to upload_part_copy and implements the parsing of the responses required to make multipart copy work.

See the spec here https://docs.aws.amazon.com/AmazonS3/latest/API/mpUploadUploadPartCopy.html

@kerryjj
Copy link
Author

kerryjj commented Apr 10, 2021

Not sure why I didn't submit this PR at the time I created this.

This fixes the issue mentioned in #46 where the upload_id and part_number are required by S3 and when calling AWS.S3.upload_part_copy.

We also weren't parsing the responses for upload part copy, so I've done that and the feature now works.

@kerryjj
Copy link
Author

kerryjj commented Apr 10, 2021

This PR also fixes #75 because ExAws.S3.Parsers.parse_complete_multipart_upload is now doing what was done in ExAws.S3.Parsers.parse_upload and from what I can see ExAws.S3.Parsers.parse_upload isn't used and can be deleted.

…mplemented by `parse_complete_multipart_upload` instead.
@bernardd
Copy link
Contributor

Hi @kerryjj - thanks very much for the patch (and especially for including tests - those always make me feel more confident about changes), and my apologies for not getting to it sooner. Would you be kind enough to resolve the conflicts with the current master, and then I'll get this merged? Thanks heaps.

@bernardd
Copy link
Contributor

Superseded by #217

@bernardd bernardd closed this Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants