Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Elixir 1.18 in GitHub CI #285

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kianmeng
Copy link
Contributor

List of changes:

_ -> "unknown"
end

path = Path.join([tmp_path(), "#{__CALLER__.module}", "#{fn_name}"])

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run mix test
  
    warning: incompatible types given to Kernel.elem/2:
        elem(__CALLER__.function, 0)
    given types:
        -nil or {atom(), integer()}-, integer()
    but expected one of:
        {...}, integer()
    typing violation found at:
    │
 21 │     path = Path.join([tmp_path(), "#{__CALLER__.module}", "#{elem(__CALLER__.function, 0)}"])
    │                                                              ~
    │
    └─ test/support/file_helpers.ex:[21](https://github.com/kianmeng/ex_aws_s3/pull/1/checks#step:9:22):62: Support.FileHelpers.in_tmp/1

List of changes:
- resolve type warnings in test case
- use specific versions by string instead of number in CI matrix, see
  https://github.com/erlef/setup-beam?tab=readme-ov-file#specify-versions-as-strings-not-numbers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant