-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: MPI support for openMP and GPU. #109
Open
bevanwsjones
wants to merge
13
commits into
main
Choose a base branch
from
93-mpi-support-for-openmp-and-gpus
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
e214c0e
- started adding memory spaces to buffer.
bevanwsjones b970741
- messing around with updateDataSize
bevanwsjones 00017f9
Merge remote-tracking branch 'origin/main' into 93-mpi-support-for-op…
bevanwsjones 07c4301
- still prototyping.
bevanwsjones 610ad7b
- going with template approach, replaced all rankOffset_ and rankBuff…
bevanwsjones 726aa97
Merge remote-tracking branch 'origin/main' into 93-mpi-support-for-op…
bevanwsjones fdcd8e8
- isComplete changed to isActive to more accurately represent the sta…
bevanwsjones 1362d4d
- removed cpp for halfDuplexCommBuffer.cpp, class is now templated.
bevanwsjones bfb087a
- Fixed bugs which were associated with the isActive() change.
bevanwsjones 0fcc6f9
- kokkos view now implemented as buffer container.
bevanwsjones 9dcbfa5
- renamed rankOffset_ to rankOffsetMPI_ in halfDuplexCommBuffer.
bevanwsjones c825291
- duplicated offsets on Host and Space pass tests for host space.
bevanwsjones b56900c
- pushes before hackathon
bevanwsjones File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For MPI these arrays needs to stay on the host. Only the send or recv buffer may be on the device, everything else has to be on the host.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But this would be a problem then, because you would have to copy from host to device to make the MPI call no? Or does MPI realise that the buffer is on the device and the rest on the host?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can't make MPI calls on the device (as in during kernels), if that is what you are asking. Other than that, the ranks, sizes, offsets, etc., are always on the host, regardless of where the buffer memory is located. MPI can automatically determine if a buffer is on the device or not.