Add an option to apply pre-commit and clang-tidy fixes #238
Conversation
greole
changed the title
.github/workflows/static_checks.yaml
Outdated
| - name: Run pre-commit on all files | ||
| run: pre-commit run --all --color always --verbose | ||
| - name: Commit pre-commit fixes | ||
| if: ${{contains(github.event.pull_request.labels.*.name, 'auto-fix') && failure()}} |
There was a problem hiding this comment.
I think you can check for the failure state of a specific step. This would also trigger, if, for example, the install dependencies step failed.
greole
force-pushed
the
enh/formating_workflow
branch
from
40022fa to
d79a82b
Compare
greole
force-pushed
the
enh/formating_workflow
branch
from
2e7dbb9 to
369f112
Compare
greole
force-pushed
the
enh/formating_workflow
branch
from
b20cb49 to
b6ed0c0
Compare
greole
force-pushed
the
enh/formating_workflow
branch
from
b6ed0c0 to
72b183e
Compare
| @@ -56,7 +56,10 @@ jobs: | |||
| uses: thollander/actions-comment-pull-request@v2 | |||
| with: | |||
| message: | | |||
| Deployed test documentation to https://exasim-project.com/NeoFOAM/Build_PR_${{ env.PR_NUMBER }} | |||
| Thank you for your PR, here are some useful tips: | |||
There was a problem hiding this comment.
The bot seems a bit spammy. Is there a way to only post once per PR?
There was a problem hiding this comment.
It should actually post it only once. I just deleted the comments of the bot to check how the most recent version renders.
There was a problem hiding this comment.
I think it's removing the old comment and adding a new one. I still got multiple emails with the same bot comment.
There was a problem hiding this comment.
I think this action should use the pull_request:open event. That would probably mean to extract it into a new file.
There was a problem hiding this comment.
ok this should be resolved now with a999de0
i just check if the bot already posted.
greole
force-pushed
the
enh/formating_workflow
branch
from
0d1a162 to
d437b4d
Compare
|
Thank you for your PR, here are some useful tips:
|
This PR modifies the static-checks workflow to commit changes if the
auto-fixlabel is set. For now, applying fixes automatically is not the default, because it might be annoying to constantly push and pull.Additional changes: