Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add executor generator for tests and benchmarks #251

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

greole
Copy link
Contributor

@greole greole commented Jan 28, 2025

This PR adds a custom generator to generate available Executors. This allows to replace

    NeoFOAM::Executor exec = GENERATE(
        NeoFOAM::Executor(NeoFOAM::SerialExecutor {}),
        NeoFOAM::Executor(NeoFOAM::CPUExecutor {}),
        NeoFOAM::Executor(NeoFOAM::GPUExecutor {})
    );

by

NeoFOAM::Executor exec = GENERATE(allAvailableExecutor());

TODO:

  • only yield every executor once. Currently, if compiled without GPUExecutor the fallback NeoFOAM::CPUExecutor is used.

Copy link

Deployed test documentation to https://exasim-project.com/NeoFOAM/Build_PR_251

@greole greole changed the title WIP Add executor generator for tests Add executor generator for tests and benchmarks Feb 9, 2025
@greole greole added the full-ci a label that triggers the full ci pipeline label Feb 9, 2025
@greole greole added the ready-for-review Set this label to indicate that the PR is ready for review label Feb 9, 2025
Copy link
Collaborator

@HenningScheufler HenningScheufler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-ci a label that triggers the full ci pipeline ready-for-review Set this label to indicate that the PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants