Xtensor template fix #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See issues: - llvm/llvm-project#91504 - xtensor-stack/xtensor#2783
unageek
added a commit
to polatory/polatory
that referenced
this pull request
Nov 15, 2024
unageek
added a commit
to polatory/polatory
that referenced
this pull request
Nov 15, 2024
unageek
added a commit
to polatory/polatory
that referenced
this pull request
Nov 15, 2024
unageek
added a commit
to polatory/polatory
that referenced
this pull request
Nov 15, 2024
unageek
added a commit
to polatory/polatory
that referenced
this pull request
Nov 15, 2024
unageek
added a commit
to polatory/polatory
that referenced
this pull request
Nov 15, 2024
unageek
added a commit
to polatory/polatory
that referenced
this pull request
Nov 15, 2024
unageek
added a commit
to polatory/polatory
that referenced
this pull request
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for newer versions of LLVM that are having some sort of interaction with xtensor that is causing issues. Notably, this will also affect the main development branch of OpenMC eventually, though is much more of a present issue for the OMP fork given our reliance on newer compilers.
The intertwined issues are a little hard to parse, but I'm gathering that the issue may be in xtensor itself rather than with LLVM, but I'm not 100% on that.
Thankfully, there is an easy workaround flag that can be passed to LLVM that fixes the error. I think we should add it in now so that our auto testing works again and I'll plan on checking manually now and then to see if the flag is still required or not (and/or if an update to the xtensor submodule fixes it).
See issues: