Skip to content

Commit

Permalink
Ensure port is not empty
Browse files Browse the repository at this point in the history
  • Loading branch information
ckunki committed Sep 23, 2024
1 parent 829c480 commit b03f819
Showing 1 changed file with 6 additions and 4 deletions.
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import pytest
import pyexasol
from typing import Tuple
from typing import Any, Tuple
from exasol_advanced_analytics_framework.deployment.scripts_deployer import ScriptsDeployer


Expand Down Expand Up @@ -54,18 +54,20 @@ def _deploy_scripts(db_conn) -> None:
# }


def _bucket_address(bucketfs_params) -> str:
import re
def _bucket_address(bucketfs_params: dict[str, Any]) -> str:
# pytest-plugins/pytest-slc/exasol/pytest_slc/__init__.py defines
BFS_CONTAINER_DIRECTORY = 'container'
host_and_port = bucketfs_params["url"]
port = ":6666" if not re.search(":[0-9]+$", host_and_port) else ""
bucket_name = bucketfs_params["bucket_name"]
path_in_bucket = BFS_CONTAINER_DIRECTORY
service_name = bucketfs_params["service_name"]
return ( f"http://{host_and_port}/{bucket_name}/"
return ( f"http://{host_and_port}{port}/{bucket_name}/"
f"{path_in_bucket};{service_name}" )


def _create_bucketfs_connection(use_onprem, db_conn, bucketfs_params) -> str:
def _create_bucketfs_connection(use_onprem, db_conn, bucketfs_params: dict[str, Any]) -> str:
name = BUCKETFS_CONNECTION_NAME
if use_onprem:
# In general currently I disabled SaaS backend for AAF.
Expand Down

0 comments on commit b03f819

Please sign in to comment.