Feature/add extension manager #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaklakariada
requested changes
Sep 25, 2023
Co-authored-by: Christoph Pirkl <[email protected]>
This reverts commit 3c226a7.
+ add exclude for ci-build for older runner workaround
Co-authored-by: Christoph Pirkl <[email protected]>
added package info to CVE excludes
- release notes
kaklakariada
requested changes
Oct 17, 2023
…m/exasol/kafka-connector-extension into feature/add_extension_manager_wip
Co-authored-by: Christoph Pirkl <[email protected]>
Co-authored-by: Christoph Pirkl <[email protected]>
…m/exasol/kafka-connector-extension into feature/add_extension_manager_wip
kaklakariada
previously approved these changes
Oct 17, 2023
java.lang.NoSuchMethodError: 'void org.eclipse.jetty.server.Server.addEventListener(org.eclipse.jetty.util.component.Container$Listener)' at io.confluent.rest.ApplicationServer.<init>(ApplicationServer.java:108) at io.confluent.rest.ApplicationServer.<init>(ApplicationServer.java:92) at io.confluent.rest.Application.createServer(Application.java:278) at io.confluent.rest.Application.start(Application.java:757) at io.github.embeddedkafka.schemaregistry.ops.SchemaRegistryOps.startSchemaRegistry(SchemaRegistryOps.scala:44) at io.github.embeddedkafka.schemaregistry.ops.SchemaRegistryOps.startSchemaRegistry$(SchemaRegistryOps.scala:21) at io.github.embeddedkafka.schemaregistry.EmbeddedKafka$.startSchemaRegistry(EmbeddedKafka.scala:70) at io.github.embeddedkafka.schemaregistry.EmbeddedKafka$.start(EmbeddedKafka.scala:96) at com.exasol.cloudetl.kafka.KafkaIntegrationTest.beforeAll(KafkaIntegrationTest.scala:39) at com.exasol.cloudetl.kafka.KafkaIntegrationTest.beforeAll$(KafkaIntegrationTest.scala:38)
since the ci build workflow is custom it is excluded in project keeper as well
- extracted producer method + moved call to actual test
|
Kudos, SonarCloud Quality Gate passed!
|
kaklakariada
approved these changes
Oct 18, 2023
| @@ -145,6 +145,7 @@ void installingTwiceCreatesScripts() { | |||
| @Test | |||
| void importWorksAfterInstallation() throws SQLException { | |||
| setup.client().install(); | |||
| kafkaSetup.produceTestTopicRecords(); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #72