Integrate review feedback

exasol · Mar 13, 2024 · 43ac47c · 43ac47c
1 parent 52474f7
commit 43ac47c
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/exasol/toolbox/release/__init__.py b/exasol/toolbox/release/__init__.py
@@ -49,6 +49,11 @@ def __eq__(self, other):
     @staticmethod
     def from_string(version):
         parts = [int(number, base=0) for number in version.split(".")]
+        if len(parts) > 3:
+            raise ValueError(
+                    "Version has an invalid format, " 
+                    f"expected: '<major>.<minor>.<patch>', actual: '{version}'"
+            )
         version = [_index_or(parts, i, 0) for i in range(3)]
         return Version(*version)
 

diff --git a/test/unit/cli_test.py b/test/unit/cli_test.py
@@ -9,6 +9,7 @@
 @pytest.mark.parametrize(
     "version_string,expected_error",
     [
+        ("4.4.4.4", ArgumentTypeError),
         ("1.b.a", ArgumentTypeError),
         ("F.b.a", ArgumentTypeError),
         ("F", ArgumentTypeError),

diff --git a/test/unit/git_test.py b/test/unit/git_test.py
@@ -15,16 +15,16 @@ def git_tag():
         stdout=cleandoc(
             """
             0.0.1
+            0.6.2
             0.1.0
             0.2.0
+            0.5.0
             0.3.0
             0.4.0
-            0.5.0
             0.6.0
             0.6.1
-            0.6.2
-            0.7.0
             0.8.0
+            0.7.0
             """
         ).encode("utf8"),
         stderr="",