Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📚 Add comment to workflow files #160

Open
ckunki opened this issue Apr 19, 2024 · 0 comments
Open

📚 Add comment to workflow files #160

ckunki opened this issue Apr 19, 2024 · 0 comments
Labels
documentation User guides, tutorials, specifications
Milestone

Comments

@ckunki
Copy link
Contributor

ckunki commented Apr 19, 2024

Background & Context

@tkilias and I were wondering and discussing why the following section is included in the GitHub workflows proposed by PTB:

  pull_request:
    types: [opened, reopened]

We imagined the following rationale:

  • At the time when the pr is opened or reopened, the check results of former push operation could already be outdated
  • So the PR should run the checks again

Acceptance Criteria

  • A comment is added to the workflow files provided by the PTB, e.g. # check results of former push could be outdated
  • Optionally: An additional section is added to the developer guide explaining rationale and mitigation in more details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation User guides, tutorials, specifications
Projects
None yet
Development

No branches or pull requests

2 participants