Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#8 add ci task to check if the generated api is outdated #12

Merged

Conversation

ckunki
Copy link
Collaborator

@ckunki ckunki commented Apr 19, 2024

Closes #8

doc/developer_guide/developer_guide.md Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
noxfile.py Outdated Show resolved Hide resolved
noxfile.py Show resolved Hide resolved
@ckunki ckunki requested a review from tkilias April 19, 2024 08:15
branches-ignore:
- "github-pages/*"
- "gh-pages/*"
- "main"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why shouldn't it run on main

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied the code from ci.yml which was generated by PTB.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the intention is to run checks only once (on the branch) but not another time (after merging).

.github/workflows/check-api-outdated.yml Show resolved Hide resolved
noxfile.py Outdated Show resolved Hide resolved
@ckunki ckunki merged commit a84e6e8 into main Apr 19, 2024
7 checks passed
@ckunki ckunki deleted the feature/#8-Add_CI_task_to_check_if_the_generated_API_is_outdated branch April 19, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI task to check if the generated API is outdated
2 participants