Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#125 Moved to Python3.10 [run aws tests] #130

Merged
merged 5 commits into from
Jun 20, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/actions/prepare_poetry_env/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ inputs:
python-version:
description: 'The Python version to use'
required: true
default: '3.8'
default: '3.10'
runs:
using: "composite"
steps:
Expand All @@ -13,7 +13,7 @@ runs:
python-version: ${{ inputs.python-version }}
- uses: abatilo/actions-poetry@v2
with:
poetry-version: 1.4.0
poetry-version: 1.8.0
- name: Poetry install
run: poetry install
shell: bash
4 changes: 2 additions & 2 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: [3.8]
python-version: [3.10]
runs-on: ubuntu-20.04
environment: aws

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3

- name: Setup Python & Poetry Environment
uses: ./.github/actions/prepare_poetry_env
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/language_container.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3

- name: Setup Python & Poetry Environment
uses: ./.github/actions/prepare_poetry_env
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,14 @@ jobs:
release:
strategy:
matrix:
python-version: [ 3.8 ]
python-version: [ 3.10 ]
ckunki marked this conversation as resolved.
Show resolved Hide resolved
runs-on: ubuntu-latest

env:
RELEASE_DIR: ".build_output/exported_container"

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3

- name: Setup Python & Poetry Environment
uses: ./.github/actions/prepare_poetry_env
Expand Down
7 changes: 4 additions & 3 deletions doc/changes/changes_0.10.0.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
# SageMaker Extension 0.10.0, released T.B.D.
# SageMaker Extension 0.10.0, released 2024-06-20

Code name: T.B.D.
Code name: Python 3.10

## Summary

T.B.D.
Improving documentation, refactoring and moving to Python 3.10

### Features

Expand All @@ -22,3 +22,4 @@ n/a
### Refactoring

- #118: Refactor to use python-extension-common package
- #124: Moved to Python 3.10
2 changes: 1 addition & 1 deletion doc/dependencies.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

| Dependency | Purpose | License |
|-------------------------------|--------------------------------------------|--------------------|
| [Python 3][python] | Python version 3.8 and above | PSF |
| [Python 3][python] | Python version 3.10 and above | PSF |
| [AWS SageMaker][sagemaker] | Allows to train ML models on AWS Sagemaker | Apache License 2.0 |
| [AWS Boto] [boto] | Makes use of AWS services for Python | Apache License 2.0 |

Expand Down
2 changes: 1 addition & 1 deletion doc/developer_guide/developer_guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ In this developer guide we explain how you can build and run this project.
## Building the Project

### 1. Build the Python Package
This project needs python interpreter Python 3.8 or above installed on the
This project needs python interpreter Python 3.10 or above installed on the
development machine. In addition, in order to build python packages you need to
have >= [poetry](https://python-poetry.org/) 1.1.11 package manager. Then you can
install and build as follows:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
FROM exasol/script-language-container:python-3.8-minimal-EXASOL-6.2.0-release_Y5KJTLX3TPPOSDA2SQMX6QGAAMY5BG5SFY2MMXLMQ5RM6T53UFTA
FROM exasol/script-language-container:template-Exasol-all-python-3.10-build_run_BUXX2FHQPEBXZNMS6RQRXPKRMKZREERZ5HIRVNXTV56DLNXXTGQA

COPY release/dist /project
RUN pip install /project/*.whl


RUN mkdir -p /build_info/actual_installed_packages/release && \
/scripts/list_installed_scripts/list_installed_apt.sh > /build_info/actual_installed_packages/release/apt_get_packages && \
/scripts/list_installed_scripts/list_installed_pip.sh python3.8 > /build_info/actual_installed_packages/release/python3_pip_packages
/scripts/list_installed_scripts/list_installed_pip.sh python3.10 > /build_info/actual_installed_packages/release/python3_pip_packages
238 changes: 110 additions & 128 deletions poetry.lock

Large diffs are not rendered by default.

5 changes: 2 additions & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ keywords = ['exasol', 'sagemaker']
include = ["lua", "resources", "deployment"]

[tool.poetry.dependencies]
python = ">=3.8,<4.0"
python = ">=3.10,<4.0"
pandas = ">=1.4.2,<2.0.0"
boto3 = "1.26.163"
botocore = "1.29.163"
Expand All @@ -29,8 +29,7 @@ sagemaker = "^2.59.1"
pyexasol = "^0.25.0"
importlib-resources = "^5.2.0"
click = "^8.0.3"
# TODO: replace with released version on release
python-extension-common = {git = "https://github.com/exasol/python-extension-common.git", branch = "main"}
exasol-python-extension-common = ">=0.2.0"

[tool.poetry.dev-dependencies]
pytest = "^7.1"
Expand Down
Loading