Skip to content

Commit

Permalink
Deactivate slow tests under valgrind
Browse files Browse the repository at this point in the history
  • Loading branch information
tomuben committed Oct 11, 2024
1 parent f9663d1 commit c53ce9e
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/check_bazel_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,13 @@ jobs:
name: "script_options_parser_ctpg"
- test: "//base/script_options_parser/legacy/..."
name: "script_options_parser_legacy"
- test: "--run_under='valgrind' //base/javacontainer/test:javacontainer-test-legacy-parser"
- test: "--run_under='valgrind' --copt -DVALGRIND_ACTIVE //base/javacontainer/test:javacontainer-test-legacy-parser"
name: "javacontainer-test-legacy-parser-with-valgrind"
- test: "--run_under='valgrind' //base/javacontainer/test:javacontainer-test-ctpg-parser"
- test: "--run_under='valgrind' --copt -DVALGRIND_ACTIVE //base/javacontainer/test:javacontainer-test-ctpg-parser"
name: "javacontainer-test-ctpg-parser-with-valgrind"
- test: "--run_under='valgrind' --test_timeout=3600 //base/script_options_parser/ctpg/..."
- test: "--run_under='valgrind' --copt -DVALGRIND_ACTIVE //base/script_options_parser/ctpg/..."
name: "script_options_parser_ctpg_with_valgrind"
- test: "--run_under='valgrind' //base/script_options_parser/legacy/..."
- test: "--run_under='valgrind' --copt -DVALGRIND_ACTIVE //base/script_options_parser/legacy/..."
name: "script_options_parser_legacy_with_valgrind"
- test: "--config=asan //base/javacontainer/test:javacontainer-test-legacy-parser"
name: "javacontainer-test-legacy-parser-with-asan"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ inline ScriptOption buildOption(const char* value, size_t idx, size_t len) {
return option;
}

#ifndef VALGRIND_ACTIVE

class ScriptOptionLinesWhitespaceTest : public ::testing::TestWithParam<std::tuple<std::string, std::string, std::string, std::string, std::string, std::string, std::string>> {};

TEST_P(ScriptOptionLinesWhitespaceTest, WhitespaceExtractOptionLineTest) {
Expand Down Expand Up @@ -58,6 +60,8 @@ INSTANTIATE_TEST_SUITE_P(
)
);

#endif //VALGRIND_ACTIVE

TEST(ScriptOptionLinesTest, ignore_anything_other_than_whitepsace) {
const std::string code =
"abc %option myoption;\n"
Expand Down

0 comments on commit c53ce9e

Please sign in to comment.