Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#857: Updated R to 4.3 and the R package in standard 7.1 flavor #392

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

tkilias
Copy link
Collaborator

@tkilias tkilias commented Nov 22, 2023

@@ -184,8 +185,8 @@ def run(ctx):
importer.import_modules()
/
'''))
with UdfDebugger(test_case=self):
rows = self.query('''SELECT scikit_learn.import_scikit_learn() FROM dual''')
#with UdfDebugger(test_case=self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#with UdfDebugger(test_case=self):

Copy link
Collaborator Author

@tkilias tkilias Nov 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left, that intentional, because it is likely, that this often needed for debugging, but in we shouldn't keep it in the CI, because it can be a little bit flaky.

@tkilias tkilias merged commit 39fcb6e into master Nov 22, 2023
10 checks passed
@tkilias tkilias deleted the refactoring/857_update_r43_in_standard_71 branch November 22, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants