testing CI, final adjustments, cleaning up code, preparing for release #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- timestamp with timezone -> timezone - warning for NUMBER with precision > 36 - 'character' is an alias for varchar in snowflake so it gets converted to varchar and there's no padding
pj-spoelders
changed the title
pj-spoelders
changed the title
- update .gitattributes - remove stale todo comments - update exasolDbversions in project-keeper.yml
- Use TestConfig + test.properties file instead of 3 different files for accountname, username & password
kaklakariada
requested changes
Sep 27, 2024
There was a problem hiding this comment.
General: Indentation of Java files is broken for some files. Please run formatter for all files.
Also I am not sure if all findings from #4 are implemented here, or do you want to implement them in another PR?
|
I seem to have missed a bunch of the other review's comments .. working on it. |
kaklakariada
approved these changes
Oct 1, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1