Skip to content

Commit

Permalink
Add rationale for source & target configuration
Browse files Browse the repository at this point in the history
  • Loading branch information
kaklakariada committed Mar 14, 2024
1 parent 8442abd commit 6a9f818
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -174,11 +174,13 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<!-- Override Java version -->
<!-- We build for Java 8 but some test dependencies require JDK 11.
So we build with JDK 11 and set source and target to 8.
This requires excluding compiler warning below. -->
<source>8</source>
<target>8</target>
<compilerArgs>
<!-- Excluding [options] bootstrap class path not set in conjunction with -source 8 -->
<!-- Excluding "[options] bootstrap class path not set in conjunction with -source 8" -->
<arg>-Xlint:all,-processing,-path,-options</arg>
<arg>-Werror</arg>
</compilerArgs>
Expand Down

0 comments on commit 6a9f818

Please sign in to comment.