Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binary search tree #299

Merged
merged 7 commits into from
Nov 10, 2024
Merged

Binary search tree #299

merged 7 commits into from
Nov 10, 2024

Conversation

0xNeshi
Copy link
Contributor

@0xNeshi 0xNeshi commented Oct 30, 2024

Closes #166

@0xNeshi 0xNeshi added x:module/practice-exercise Work on Practice Exercises x:type/content Work on content (e.g. exercises, concepts) x:rep/large Large amount of reputation x:action/create Work on something from scratch x:type/coding Write code that is not student-facing content (e.g. test-runners, generators, but not exercises) labels Oct 30, 2024
@0xNeshi 0xNeshi self-assigned this Oct 30, 2024
@github-actions GitHub Actions
Copy link

Hello 👋 Thanks for your PR.

This repo does not currently have dedicated maintainers. Our cross-track maintainers team will attempt to review and merge your PR, but it will likely take longer for your PR to be reviewed.

If you enjoy contributing to Exercism and have a track-record of doing so successfully, you might like to become an Exercism maintainer for this track.

Please feel free to ask any questions, or chat to us about anything to do with this PR or the reviewing process on the Exercism forum.

(cc @exercism/cross-track-maintainers)

BNAndras
BNAndras previously approved these changes Oct 31, 2024
View reviewed changes
@0xNeshi 0xNeshi marked this pull request as draft October 31, 2024 15:14
@0xNeshi
Copy link
Contributor Author

0xNeshi commented Oct 31, 2024

I think I have a much more elegant solution, will rework

@0xNeshi 0xNeshi marked this pull request as ready for review October 31, 2024 18:42
@0xNeshi 0xNeshi requested a review from BNAndras October 31, 2024 18:42
@0xNeshi 0xNeshi dismissed BNAndras’s stale review October 31, 2024 18:43

Reimplemented the exercise using a completely different approach, interested what you think

@0xNeshi
Copy link
Contributor Author

0xNeshi commented Nov 3, 2024

@BNAndras pinging you in case you didn't get a notification that I re-requested your review

@BNAndras
Copy link
Member

BNAndras commented Nov 4, 2024

I can take a look later this week.

@0xNeshi 0xNeshi merged commit 2f5bd88 into main Nov 10, 2024
6 checks passed
@0xNeshi 0xNeshi deleted the binary-search-tree branch November 10, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BNAndras BNAndras BNAndras approved these changes

Assignees

@0xNeshi 0xNeshi

Labels
x:action/create Work on something from scratch x:module/practice-exercise Work on Practice Exercises x:rep/large Large amount of reputation x:type/coding Write code that is not student-facing content (e.g. test-runners, generators, but not exercises) x:type/content Work on content (e.g. exercises, concepts)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Practice Exercise: binary-search-tree
2 participants
@0xNeshi @BNAndras