Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Felt type introduction added #56

Merged
merged 5 commits into from
Jul 2, 2024
Merged

Felt type introduction added #56

merged 5 commits into from
Jul 2, 2024

Conversation

rajeebkm
Copy link
Contributor

@rajeebkm rajeebkm commented Jul 2, 2024 •
edited by 0xNeshi
Loading

Closes #33

  • Felt type Introduction.md updated
  • Felt type about.md updated

0xNeshi
0xNeshi requested changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@0xNeshi 0xNeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The concept looks good, left some small change requests

concepts/felts/introduction.md Outdated Show resolved Hide resolved
concepts/felts/introduction.md Outdated Show resolved Hide resolved
concepts/felts/about.md Outdated Show resolved Hide resolved
concepts/felts/about.md Outdated Show resolved Hide resolved
concepts/felts/about.md Outdated Show resolved Hide resolved
concepts/felts/about.md Outdated Show resolved Hide resolved
concepts/felts/about.md Outdated Show resolved Hide resolved
concepts/felts/about.md Outdated Show resolved Hide resolved
concepts/felts/about.md Show resolved Hide resolved
rajeebkm
rajeebkm commented Jul 2, 2024
View reviewed changes
Copy link
Contributor Author

@rajeebkm rajeebkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Change request resolved.

0xNeshi
0xNeshi approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@0xNeshi 0xNeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks beautiful, thanks!

@0xNeshi 0xNeshi merged commit bcc6506 into exercism:main Jul 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xNeshi 0xNeshi 0xNeshi approved these changes

Assignees

@rajeebkm rajeebkm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write the "Felt Type" concept
2 participants
@rajeebkm @0xNeshi