Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integer and boolean type introduction & about #66

Merged
merged 10 commits into from
Jul 12, 2024
Merged

Conversation

rajeebkm
Copy link
Contributor

@rajeebkm rajeebkm commented Jul 8, 2024

Closes #34, Closes #32

  • Integer type introduction and about are added.

@rajeebkm rajeebkm changed the title Integer type introduction & about Integer and boolean type introduction & about Jul 8, 2024
Copy link
Contributor

@0xNeshi 0xNeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Left a couple of nits and a suggestion to add info on boolean operators

concepts/booleans/links.json Outdated Show resolved Hide resolved
concepts/booleans/about.md Outdated Show resolved Hide resolved
concepts/booleans/about.md Outdated Show resolved Hide resolved
concepts/booleans/about.md Outdated Show resolved Hide resolved
concepts/booleans/about.md Outdated Show resolved Hide resolved
concepts/booleans/about.md Show resolved Hide resolved
Copy link
Contributor

@0xNeshi 0xNeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. One small nit and we can merge

concepts/booleans/about.md Outdated Show resolved Hide resolved
Copy link
Contributor

@0xNeshi 0xNeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected one small issue that caused the boolean example not to compile, didn't want to bother you again. Just a note so that you're aware - assert expects its error message to be of type felt252, so you can't use double quotes " ", but single ones ' '. If you wish to use double quotes, i.e. ByteArrays, you should use the assert! macro (note the ! at the end).

So instead of:

// doesn't compile
assert(t == true_expr, "this should be true");

You should write one of the below:

// use felts
assert(t == true_expr, 'this should be true');
// use macro
assert!(t == true_expr, "this should be true");

@0xNeshi 0xNeshi merged commit a80e878 into exercism:main Jul 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write the "The Boolean Type" concept Write the "Integers" concept
2 participants