-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integer and boolean type introduction & about #66
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Left a couple of nits and a suggestion to add info on boolean operators
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. One small nit and we can merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected one small issue that caused the boolean example not to compile, didn't want to bother you again. Just a note so that you're aware - assert
expects its error message to be of type felt252
, so you can't use double quotes " "
, but single ones ' '
. If you wish to use double quotes, i.e. ByteArrays, you should use the assert!
macro (note the !
at the end).
So instead of:
// doesn't compile
assert(t == true_expr, "this should be true");
You should write one of the below:
// use felts
assert(t == true_expr, 'this should be true');
// use macro
assert!(t == true_expr, "this should be true");
Closes #34, Closes #32