Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Welcome Modal Remaining Stuck After Successful Dismissal #6599

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

dem4ron
Copy link
Member

@dem4ron dem4ron commented Dec 11, 2023

No description provided.

Comment on lines 35 to 36
onError: (e) => {
console.log('this is an error:', e)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this temporary? I mean: it doesn't offer any value to the student :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, removing it. Thanks!

@iHiD iHiD merged commit e83e73c into main Dec 13, 2023
39 checks passed
@iHiD iHiD deleted the fix-welcome-modal branch December 13, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants