Allow specifying groups option in submit command

expo · Feb 7, 2025 · 4892814 · 4892814
1 parent f334bdb
commit 4892814
Show file tree

Hide file tree

Showing 10 changed files with 39 additions and 1 deletion.
diff --git a/packages/eas-cli/src/build/runBuildAndSubmit.ts b/packages/eas-cli/src/build/runBuildAndSubmit.ts
@@ -522,6 +522,7 @@ async function prepareAndStartSubmissionAsync({
     exp: buildCtx.exp,
     vcsClient: buildCtx.vcsClient,
     isVerboseFastlaneEnabled: false,
+    groups: [],
     specifiedProfile: selectedSubmitProfileName,
   });
 

diff --git a/packages/eas-cli/src/commands/submit.ts b/packages/eas-cli/src/commands/submit.ts
@@ -34,6 +34,7 @@ interface RawCommandFlags {
   wait: boolean;
   'non-interactive': boolean;
   'verbose-fastlane': boolean;
+  groups?: string[];
 }
 
 interface CommandFlags {
@@ -44,6 +45,7 @@ interface CommandFlags {
   wait: boolean;
   nonInteractive: boolean;
   isVerboseFastlaneEnabled: boolean;
+  groups?: string[];
 }
 
 export default class Submit extends EasCommand {
@@ -89,6 +91,11 @@ export default class Submit extends EasCommand {
       default: false,
       description: 'Enable verbose logging for the submission process',
     }),
+    groups: Flags.string({
+      description: 'Testing groups to send the build to (iOS only).',
+      multiple: true,
+      char: 'g',
+    }),
     'non-interactive': Flags.boolean({
       default: false,
       description: 'Run command in non-interactive mode',
@@ -140,6 +147,7 @@ export default class Submit extends EasCommand {
         archiveFlags: flagsWithPlatform.archiveFlags,
         nonInteractive: flagsWithPlatform.nonInteractive,
         isVerboseFastlaneEnabled: flagsWithPlatform.isVerboseFastlaneEnabled,
+        groups: flagsWithPlatform.groups ?? [],
         actor,
         graphqlClient,
         analytics,
@@ -184,6 +192,7 @@ export default class Submit extends EasCommand {
       profile,
       'non-interactive': nonInteractive,
       'verbose-fastlane': isVerboseFastlaneEnabled,
+      groups,
       ...archiveFlags
     } = flags;
 
@@ -205,6 +214,7 @@ export default class Submit extends EasCommand {
       profile,
       nonInteractive,
       isVerboseFastlaneEnabled,
+      groups,
     };
   }
 

diff --git a/packages/eas-cli/src/commands/submit/internal.ts b/packages/eas-cli/src/commands/submit/internal.ts
@@ -89,6 +89,7 @@ export default class SubmitInternal extends EasCommand {
       },
       nonInteractive: true,
       isVerboseFastlaneEnabled: false,
+      groups: [],
       actor,
       graphqlClient,
       analytics,

diff --git a/packages/eas-cli/src/graphql/generated.ts b/packages/eas-cli/src/graphql/generated.ts
diff --git a/packages/eas-cli/src/submit/android/__tests__/AndroidSubmitCommand-test.ts b/packages/eas-cli/src/submit/android/__tests__/AndroidSubmitCommand-test.ts
@@ -124,6 +124,7 @@ describe(AndroidSubmitCommand, () => {
         },
         nonInteractive: true,
         isVerboseFastlaneEnabled: false,
+        groups: [],
         actor: mockJester,
         graphqlClient,
         analytics,
@@ -163,6 +164,7 @@ describe(AndroidSubmitCommand, () => {
         },
         nonInteractive: false,
         isVerboseFastlaneEnabled: false,
+        groups: [],
         actor: mockJester,
         graphqlClient,
         analytics,
@@ -210,6 +212,7 @@ describe(AndroidSubmitCommand, () => {
         },
         nonInteractive: false,
         isVerboseFastlaneEnabled: false,
+        groups: [],
         actor: mockJester,
         graphqlClient,
         analytics,
@@ -260,6 +263,7 @@ describe(AndroidSubmitCommand, () => {
         },
         nonInteractive: false,
         isVerboseFastlaneEnabled: false,
+        groups: [],
         actor: mockJester,
         graphqlClient,
         analytics,
@@ -325,6 +329,7 @@ describe(AndroidSubmitCommand, () => {
           },
           nonInteractive: false,
           isVerboseFastlaneEnabled: false,
+          groups: [],
           actor: mockJester,
           graphqlClient,
           analytics,
@@ -388,6 +393,7 @@ describe(AndroidSubmitCommand, () => {
           },
           nonInteractive: false,
           isVerboseFastlaneEnabled: false,
+          groups: [],
           actor: mockJester,
           graphqlClient,
           analytics,
@@ -458,6 +464,7 @@ describe(AndroidSubmitCommand, () => {
           },
           nonInteractive: false,
           isVerboseFastlaneEnabled: false,
+          groups: [],
           actor: mockJester,
           graphqlClient,
           analytics,

diff --git a/packages/eas-cli/src/submit/android/__tests__/ServiceAccountSource-test.ts b/packages/eas-cli/src/submit/android/__tests__/ServiceAccountSource-test.ts
@@ -157,6 +157,7 @@ describe(getServiceAccountKeyResultAsync, () => {
       },
       nonInteractive: true,
       isVerboseFastlaneEnabled: false,
+      groups: [],
       actor: mockJester,
       graphqlClient,
       analytics,
@@ -200,6 +201,7 @@ describe(getServiceAccountKeyResultAsync, () => {
       },
       nonInteractive: true,
       isVerboseFastlaneEnabled: false,
+      groups: [],
       actor: mockJester,
       graphqlClient,
       analytics,
@@ -239,6 +241,7 @@ describe(getServiceAccountKeyResultAsync, () => {
       },
       nonInteractive: true,
       isVerboseFastlaneEnabled: false,
+      groups: [],
       actor: mockJester,
       graphqlClient,
       analytics,

diff --git a/packages/eas-cli/src/submit/context.ts b/packages/eas-cli/src/submit/context.ts
@@ -22,6 +22,7 @@ export interface SubmissionContext<T extends Platform> {
   exp: ExpoConfig;
   nonInteractive: boolean;
   isVerboseFastlaneEnabled: boolean;
+  groups: string[];
   platform: T;
   profile: SubmitProfile<T>;
   projectDir: string;
@@ -48,6 +49,7 @@ export async function createSubmissionContextAsync<T extends Platform>(params: {
   env?: Record<string, string>;
   nonInteractive: boolean;
   isVerboseFastlaneEnabled: boolean;
+  groups: string[];
   platform: T;
   profile: SubmitProfile<T>;
   projectDir: string;

diff --git a/packages/eas-cli/src/submit/ios/IosSubmitter.ts b/packages/eas-cli/src/submit/ios/IosSubmitter.ts
@@ -125,11 +125,12 @@ export default class IosSubmitter extends BaseSubmitter<
   ): IosSubmissionConfigInput {
     const { appSpecificPassword, ascApiKeyResult } = credentials;
     const { appleIdUsername, ascAppIdentifier } = options;
-    const { isVerboseFastlaneEnabled } = this.ctx;
+    const { isVerboseFastlaneEnabled, groups } = this.ctx;
     return {
       ascAppIdentifier,
       appleIdUsername,
       isVerboseFastlaneEnabled,
+      groups,
       ...(appSpecificPassword ? this.formatAppSpecificPassword(appSpecificPassword) : null),
       ...(ascApiKeyResult?.result ? this.formatAscApiKeyResult(ascApiKeyResult.result) : null),
     };

diff --git a/packages/eas-cli/src/submit/ios/__tests__/AscApiKeySource-test.ts b/packages/eas-cli/src/submit/ios/__tests__/AscApiKeySource-test.ts
@@ -58,6 +58,7 @@ async function getIosSubmissionContextAsync(): Promise<SubmissionContext<Platfor
     },
     nonInteractive: true,
     isVerboseFastlaneEnabled: false,
+    groups: [],
     actor: mockJester,
     graphqlClient,
     analytics,
@@ -251,6 +252,7 @@ describe(getAscApiKeyResultAsync, () => {
       },
       nonInteractive: true,
       isVerboseFastlaneEnabled: false,
+      groups: [],
       actor: mockJester,
       graphqlClient,
       analytics,

diff --git a/packages/eas-cli/src/submit/ios/__tests__/IosSubmitCommand-test.ts b/packages/eas-cli/src/submit/ios/__tests__/IosSubmitCommand-test.ts
@@ -101,6 +101,7 @@ describe(IosSubmitCommand, () => {
       },
       nonInteractive: false,
       isVerboseFastlaneEnabled: false,
+      groups: [],
       actor: mockJester,
       graphqlClient,
       analytics,
@@ -136,6 +137,7 @@ describe(IosSubmitCommand, () => {
         },
         nonInteractive: true,
         isVerboseFastlaneEnabled: false,
+        groups: [],
         actor: mockJester,
         graphqlClient,
         analytics,
@@ -174,6 +176,7 @@ describe(IosSubmitCommand, () => {
         },
         nonInteractive: false,
         isVerboseFastlaneEnabled: false,
+        groups: ['Test'],
         actor: mockJester,
         graphqlClient,
         analytics,
@@ -193,6 +196,7 @@ describe(IosSubmitCommand, () => {
           appleAppSpecificPassword: 'abcd-abcd-abcd-abcd',
           ascAppIdentifier: '12345678',
           isVerboseFastlaneEnabled: false,
+          groups: ['Test'],
         },
         submittedBuildId: undefined,
       });
@@ -240,6 +244,7 @@ describe(IosSubmitCommand, () => {
           },
           nonInteractive: false,
           isVerboseFastlaneEnabled: false,
+          groups: [],
           actor: mockJester,
           graphqlClient,
           analytics,
@@ -259,6 +264,7 @@ describe(IosSubmitCommand, () => {
             appleAppSpecificPassword: 'abcd-abcd-abcd-abcd',
             ascAppIdentifier: '87654321',
             isVerboseFastlaneEnabled: false,
+            groups: [],
           },
           archiveSource: undefined,
         });
@@ -300,6 +306,7 @@ describe(IosSubmitCommand, () => {
           },
           nonInteractive: false,
           isVerboseFastlaneEnabled: false,
+          groups: [],
           actor: mockJester,
           graphqlClient,
           analytics,
@@ -319,6 +326,7 @@ describe(IosSubmitCommand, () => {
             appleAppSpecificPassword: 'abcd-abcd-abcd-abcd',
             ascAppIdentifier: '12345678',
             isVerboseFastlaneEnabled: false,
+            groups: [],
           },
           archiveSource: undefined,
         });
@@ -365,6 +373,7 @@ describe(IosSubmitCommand, () => {
           },
           nonInteractive: false,
           isVerboseFastlaneEnabled: false,
+          groups: [],
           actor: mockJester,
           graphqlClient,
           analytics,
@@ -385,6 +394,7 @@ describe(IosSubmitCommand, () => {
             appleAppSpecificPassword: 'abcd-abcd-abcd-abcd',
             ascAppIdentifier: '12345678',
             isVerboseFastlaneEnabled: false,
+            groups: [],
           },
           archiveSource: undefined,
         });