Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Add more logging around creating a tarball #2890

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

sjchmiela
Copy link
Contributor

Should help debug why node_modules get included on Windows.

@sjchmiela sjchmiela added the no changelog PR that doesn't require a changelog entry label Feb 7, 2025
@sjchmiela sjchmiela requested a review from szdziedzic February 7, 2025 14:25
Copy link

github-actions bot commented Feb 7, 2025

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @radoslawkrzemien

Generated by CodeMention

Copy link

github-actions bot commented Feb 7, 2025

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

Copy link

github-actions bot commented Feb 7, 2025

Size Change: -627 B (0%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB -627 B (0%)

compressed-size-action

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.63%. Comparing base (73e0170) to head (bff56f8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/vcs/clients/git.ts 66.67% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2890      +/-   ##
==========================================
+ Coverage   52.62%   52.63%   +0.02%     
==========================================
  Files         588      588              
  Lines       23170    23183      +13     
  Branches     4852     4854       +2     
==========================================
+ Hits        12190    12201      +11     
- Misses      10014    10016       +2     
  Partials      966      966              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjchmiela sjchmiela merged commit e83061d into main Feb 7, 2025
10 of 11 checks passed
@sjchmiela sjchmiela deleted the stanley/more-debug-around-tarball branch February 7, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PR that doesn't require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants