-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eas-cli] Narrow amount of data queried for basic update channel operations #2901
[eas-cli] Narrow amount of data queried for basic update channel operations #2901
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Subscribed to pull request
Generated by CodeMention |
Size Change: +2.09 kB (0%) Total Size: 53.5 MB
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2901 +/- ##
==========================================
- Coverage 52.67% 52.65% -0.01%
==========================================
Files 588 588
Lines 23188 23193 +5
Branches 4856 4857 +1
==========================================
- Hits 12211 12210 -1
- Misses 10011 10016 +5
- Partials 966 967 +1 ☔ View full report in Codecov by Sentry. |
43b98bc
to
580e578
Compare
580e578
to
2a5a88d
Compare
✅ Thank you for adding the changelog entry! |
Why
As we've added more features, we've added more fetched data to the default fragments (UpdateFragment). But a lot of callsites don't need all the data. This PR adds a new basic query for getting just the basic info (similar to other query below).
How
Add new query, replace callsites that can be replaces (rely on tsc to tell me)
Test Plan
yarn tsc