Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add loadManyByIDsNullableAsync loader method #214

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

wschurman
Copy link
Member

Why

Found a use case for this method in our use of the entity library. Easy enough to implement.

How

Add method, add tests.

Test Plan

Run tests.

@wschurman wschurman requested review from ide and quinlanj October 4, 2023 18:04
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #214 (3e874f5) into main (d2a4405) will decrease coverage by 0.09%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
- Coverage   95.55%   95.46%   -0.09%     
==========================================
  Files          79       79              
  Lines        2068     2075       +7     
  Branches      279      258      -21     
==========================================
+ Hits         1976     1981       +5     
- Misses         91       93       +2     
  Partials        1        1              
Flag Coverage Δ
integration 95.46% <71.42%> (-0.09%) ⬇️
unittest 95.46% <71.42%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/entity/src/EnforcingEntityLoader.ts 100.00% <100.00%> (ø)
packages/entity/src/EntityLoader.ts 89.09% <50.00%> (-1.48%) ⬇️

@wschurman wschurman merged commit aad94ac into main Oct 4, 2023
1 of 3 checks passed
@wschurman wschurman deleted the @wschurman/nullable-loadmanyids branch October 4, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants