Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add two fan out methods to association loader #52

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

wschurman
Copy link
Member

Why

#45

This adds two basic fan out queries for a two-entity relation (no chain fan-outs yet).

How

  1. Add tests.
  2. Add fan out association load methods.

Test Plan

Run tests.

@wschurman wschurman requested a review from jkhales June 29, 2020 23:36
@codecov
Copy link

codecov bot commented Jun 29, 2020

Codecov Report

Merging #52 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   93.91%   93.95%   +0.04%     
==========================================
  Files          57       57              
  Lines        1347     1357      +10     
  Branches      145      147       +2     
==========================================
+ Hits         1265     1275      +10     
  Misses         81       81              
  Partials        1        1              
Flag Coverage Δ
#integration 93.95% <100.00%> (+0.04%) ⬆️
#unittest 93.95% <100.00%> (+0.04%) ⬆️
Impacted Files Coverage Δ
packages/entity/src/EntityAssociationLoader.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35db7e9...8fc6082. Read the comment docs.

Copy link

@jkhales jkhales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be really useful for building out eas updates. Thank you!

@wschurman wschurman merged commit 89cfb3d into master Jun 30, 2020
@wschurman wschurman deleted the @wschurman/joins branch June 30, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants