feature(website): make device preview panel resizable #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byCedric
changed the base branch from
main
to
@bycedric/website/appetize-js-sdk
byCedric
force-pushed
the
@bycedric/website/device-preview-resize
branch
2 times, most recently
from
9718f04 to
34ba744
Compare
byCedric
force-pushed
the
@bycedric/website/device-preview-resize
branch
from
ed3f94b to
0ed55a1
Compare
byCedric
temporarily deployed
to
website-staging
GitHub Actions
Inactive
byCedric
force-pushed
the
@bycedric/website/appetize-js-sdk
branch
from
649d32e to
d4f9919
Compare
byCedric
force-pushed
the
@bycedric/website/device-preview-resize
branch
from
0ed55a1 to
ef2805d
Compare
byCedric
commented
Feb 23, 2024
byCedric
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Follow up for #558. If we want to add device control to rotate the device, we need to allow users to resize that panel (because else it gets too small).
How
This introduces
react-resizable-panelsand implements it for the editor and preview. Note, for embeds, this won't be enabled.Test Plan
See staging.