refactor: remove unused app-param transformer #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjugi
approved these changes
Jan 11, 2025
There was a problem hiding this comment.
yeah... code comment was the only reasonable choice for this codemod.
To solve this properly we would need to modify the flow a little bit by detecting usage places and requesting for name param on each entry without enough context. I think it's not the best developer experience and not the simplest thing to implement on our side now.
Docs about the change: https://expressjs.com/en/guide/migrating-5.html#app.param
The app.param(fn) signature was used for modifying the behavior of the app.param(name, fn) function...
We can delete this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was planned to add a comment above the function, but I don't think this is the best approach. Anyone who updates to Express 5 will notice that the function will no longer be there, and adding a comment wouldn't add much. The idea behind the codemods is to update quickly and make the application compatible with the new version, meaning that a comment is not sufficient.