feat: add default option #191
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjohansebas
force-pushed
the
add-default-encoding
branch
from
37d0789
to
8880f40
Compare
bjohansebas
force-pushed
the
add-default-encoding
branch
from
8880f40
to
db89408
Compare
bjohansebas
force-pushed
the
add-default-encoding
branch
from
db89408
to
5d6a827
Compare
|
Hi @IamLizu, could you review this PR? |
|
Hey @bjohansebas 👋 Sure, I will read the relevant issues and then review this PR 👍 |
IamLizu
reviewed
Oct 4, 2024
| @@ -37,6 +37,8 @@ module.exports.filter = shouldCompress | |||
|
|
|||
| var cacheControlNoTransformRegExp = /(?:^|,)\s*?no-transform\s*?(?:,|$)/ | |||
|
|
|||
| var encodingSupported = ['*', 'gzip', 'deflate', 'identity'] | |||
There was a problem hiding this comment.
Why are we only supporting these?
There was a problem hiding this comment.
These are the options supported by the package at the moment; support for Brotli is still in progress
There was a problem hiding this comment.
Okay, then I will try to get a better understanding of this and get back to you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new option is added to determine the default behavior when
Accept-Encodingis not sent by the client, defaulting to identity.closes #83