-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kick off testing with test for hasNextPages #3
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,9 @@ | |
"description": "Node.js pagination middleware and view helpers", | ||
"main": "./index.js", | ||
"scripts": { | ||
"prepublish": "npm prune" | ||
"prepublish": "npm prune", | ||
"test": "node_modules/mocha/bin/_mocha --reporter spec test/**/*-test.js", | ||
"coverage": "istanbul cover node_modules/mocha/bin/_mocha" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
}, | ||
"repository": { | ||
"type": "git", | ||
|
@@ -20,5 +22,9 @@ | |
"lodash": "^2.4.1", | ||
"querystring": "^0.2.0" | ||
}, | ||
"devDependencies": {} | ||
"devDependencies": { | ||
"chai": "^1.9.1", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
"istanbul": "^0.3.0", | ||
"mocha": "^1.21.4" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
var paginate = require('../index'); | ||
var chai = require('chai'); | ||
|
||
chai.should(); | ||
|
||
describe('paginate', function(){ | ||
|
||
describe('.hasNextPages(req)', function(){ | ||
|
||
beforeEach(function(){ | ||
this.req = {query:{page:3}}; | ||
}); | ||
|
||
it('should return function', function(){ | ||
paginate.hasNextPages(this.req).should.be.a('function'); | ||
}); | ||
|
||
describe('the returned function', function(){ | ||
|
||
it('should return true when there are more pages', function(){ | ||
paginate.hasNextPages(this.req)(4).should.be.true; | ||
}); | ||
|
||
it('should return false when there are no more pages', function(){ | ||
paginate.hasNextPages(this.req)(3).should.be.false; | ||
}); | ||
|
||
it('should throw an error when pageCount is not a number', function(){ | ||
(function(){ | ||
paginate.hasNextPages(this.req)(''); | ||
}).should.throw(/not a number/); | ||
}); | ||
|
||
it('should throw an error when pageCount is less than zero', function(){ | ||
(function(){ | ||
paginate.hasNextPages(this.req)(''); | ||
}).should.throw(/\> 0/); | ||
}); | ||
|
||
}) | ||
|
||
}); | ||
|
||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't really include this in the readme as it isn't that important, the people who want to know test results by hand will know
npm test
anyways.