Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kick off testing with test for hasNextPages #3

Merged
merged 3 commits into from
Sep 4, 2014
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -101,3 +101,5 @@ dwsync.xml
# ------------------------------------------------------------------------------
# Add your custom excludes below
# ------------------------------------------------------------------------------

coverage/
18 changes: 18 additions & 0 deletions Readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -165,4 +165,22 @@ if paginate.hasPreviousPages || paginate.hasNextPages(pageCount)
i.fa.fa-arrow-circle-right
```

## Running Tests

To run the test suite, first invoke the following command within the repo, installing the development dependencies:

```bash
$ npm install
```

Then run the tests:

```bash
$ npm test
```

To get the coverage:

```bash
$ npm run coverage
```

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't really include this in the readme as it isn't that important, the people who want to know test results by hand will know npm test anyways.

10 changes: 8 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
"description": "Node.js pagination middleware and view helpers",
"main": "./index.js",
"scripts": {
"prepublish": "npm prune"
"prepublish": "npm prune",
"test": "node_modules/mocha/bin/_mocha --reporter spec test/**/*-test.js",
"coverage": "istanbul cover node_modules/mocha/bin/_mocha"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

},
"repository": {
"type": "git",
Expand All @@ -20,5 +22,9 @@
"lodash": "^2.4.1",
"querystring": "^0.2.0"
},
"devDependencies": {}
"devDependencies": {
"chai": "^1.9.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mocha --require should instead

"istanbul": "^0.3.0",
"mocha": "^1.21.4"
}
}
44 changes: 44 additions & 0 deletions test/index-test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
var paginate = require('../index');
var chai = require('chai');

chai.should();

describe('paginate', function(){

describe('.hasNextPages(req)', function(){

beforeEach(function(){
this.req = {query:{page:3}};
});

it('should return function', function(){
paginate.hasNextPages(this.req).should.be.a('function');
});

describe('the returned function', function(){

it('should return true when there are more pages', function(){
paginate.hasNextPages(this.req)(4).should.be.true;
});

it('should return false when there are no more pages', function(){
paginate.hasNextPages(this.req)(3).should.be.false;
});

it('should throw an error when pageCount is not a number', function(){
(function(){
paginate.hasNextPages(this.req)('');
}).should.throw(/not a number/);
});

it('should throw an error when pageCount is less than zero', function(){
(function(){
paginate.hasNextPages(this.req)('');
}).should.throw(/\> 0/);
});

})

});

});