-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat - create page by action to verify status - (TEST) #1586
base: gh-pages
Are you sure you want to change the base?
feat - create page by action to verify status - (TEST) #1586
Conversation
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…enzel/expressjs.com into feat/create-status-page
|
||
const ignoreFiles = ['resources/status-translate'] | ||
|
||
const languageBaseFiles = ['guide', 'resources', 'resources/middleware', 'starter', 'advanced', '3x', '4x', '5x'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not necessary to keep checking if the API versions are translated, and I don't think it will be necessary to keep looking at 'resources/middleware' either, as it is an external resource that is extracted by running a script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the language (th) there are translated 'resources/middleware'
https://deploy-preview-1586--expressjscom-preview.netlify.app/en/resources/status-translate
the API page has been translated into other languages
It would be better if this workflow were a task that repeats periodically and checks the labels of the PRs as proposed in #1480. |
we can create the schedule in main (gh-pages), but I don't know if the repository is configured to allow direct commits, so I want to do the same thing on every pull request |
This is potentially useful, but the whole area of localization (translation) probably needs to be reviewed and discussed more holistically... Anyway, I have a few questions & comments on this PR specifically:
TBH, I'd like to discuss localization with the @expressjs/express-tc in general, and since we may have access to IBM translation AI, consider re-translating the whole site once we get the docs ready for 5.x. |
Ref #1480