Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rules issues for update_external_docs workflow #1606

Merged
merged 3 commits into from
Oct 6, 2024

Conversation

bjohansebas
Copy link
Member

@bjohansebas bjohansebas commented Sep 11, 2024

Changes are made to run the workflow correctly and prevent this workflow from running in a forked repository.

Changes:

  • Allow the workflow to run manually
  • Now the workflow will only run in the main repository (expressjs/expressjs.com).
  • The tool is updated to use an external action allowed by the organization.
  • Automatically add the review for the @expressjs/docs-wg team.
  • Update the checkout action to its latest version

Copy link

netlify bot commented Sep 11, 2024

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit de6afc9
🔍 Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/67017329cdfe710008db0459
😎 Deploy Preview https://deploy-preview-1606--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bjohansebas
Copy link
Member Author

ping

@UlisesGascon UlisesGascon merged commit 24a104a into expressjs:gh-pages Oct 6, 2024
9 checks passed
@bjohansebas bjohansebas deleted the update-workflow branch October 6, 2024 16:31
chrisdel101 pushed a commit to chrisdel101/expressjs.com that referenced this pull request Nov 3, 2024
- Allow the workflow to run manually
- Now the workflow will only run in the main repository (expressjs/expressjs.com).
- The tool is updated to use an external action allowed by the organization.
- Automatically add the review for the @expressjs/docs-wg team.
- Update the checkout action to its latest version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants