Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat - add api 5x in menu #1613

Merged

Conversation

carlosstenzel
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Sep 13, 2024

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit 300a355
🔍 Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/66f9e1d2c8aacb0008c19141
😎 Deploy Preview https://deploy-preview-1613--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bjohansebas
Copy link
Member

It might be a good idea to add it in all languages, even if it's not translated into their language yet.

@carlosstenzel carlosstenzel changed the title feat - add api 5x in menu pt-br feat - add api 5x in menu Sep 13, 2024
Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The (beta) label has already been removed, it would be better to eliminate it from all headers

@crandmck
Copy link
Member

Yes, per #1603, v5 is no longer in beta. Please remove that from all langs.

@carlosstenzel
Copy link
Contributor Author

@bjohansebas @crandmck
I removed the 'beta' text

Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crandmck crandmck merged commit 42adb68 into expressjs:gh-pages Oct 5, 2024
7 of 8 checks passed
chrisdel101 pushed a commit to chrisdel101/expressjs.com that referenced this pull request Nov 3, 2024
* feat - add api 5x in menu pt-br

* update doc api-5x in pt-br

* chore - add api version 5x in menu - de

* chore - add api version 5x in menu - es

* chore - add api version 5x in menu - fr

* chore - add api version 5x in menu - id

* chore - add api version 5x in menu - it

* chore - add api version 5x in menu - ja

* chore - add api version 5x in menu - ko

* chore - add api version 5x in menu - ru

* chore - add api version 5x in menu - sk

* chore - add api version 5x in menu - th

* chore - add api version 5x in menu - tr

* chore - add api version 5x in menu - uk

* chore - add api version 5x in menu - uz

* chore - add api version 5x in menu - zh-cn and zh-tw

* chore - add api version 5x in menu -  zh-tw

* chore - remove text beta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants