Contributing.md Enhancement #1683
Conversation
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
chrisdel101
requested review from
wesleytodd,
crandmck,
bjohansebas and
a team
|
@chrisdel101 let's try to only modify things related to contributing in this PR; I'll review this PR in detail over the weekend. |
chrisdel101
force-pushed
the
contributing
branch
3 times, most recently
from
4283961
to
44cb937
Compare
Done. Please run the pipeline |
| > [!IMPORTANT] | ||
| > We are currently working toward a more streamlined translations workflow. As long as this notice is posted, we will _not_ be accepting any translation submissions. |
There was a problem hiding this comment.
Considering that this will be reflected on the website, I wonder how it will look there, since it hasn't appeared yet. Maybe you should run the script to preview it.
There was a problem hiding this comment.
Ahh your right.
I ran the script over and over on my account to test but it doesn't have the commit access to persist the file, so I must have missed this. Thanks!
Will figure out something here and get back. Would like to keep this styling for the GH side, but the website cannot be like this.
There was a problem hiding this comment.
I've changed it to this in the website file in both sections it occurs. And checked the link at the top of the page that goes here still works.
- apply all branch changes
changes to soften workflow language
Add gh important tags to top of page
chrisdel101
force-pushed
the
contributing
branch
2 times, most recently
from
7eeeb5a
to
c6af18e
Compare
chrisdel101
force-pushed
the
contributing
branch
from
c6af18e
to
3ab360c
Compare
This is a redo of #1671 (which was bungled) and a realization of #1608.
This changes are all made to the
CONTRIBUTING.mdallowing this file to remain in the repo. This is then copied into the/resources/contributing.mdpage (at the bottom).All the text content here is fair game for edits, so if any language is unsuitable, something is incorrect, or you just don't like something it can be changed or removed.
The idea here was just to give a more detailed outline of how to contribute, so if the workflow for that is wrong, it can be corrected.
I left the translation sections in, but with notices of suspension.
Also looks like I cannot run the
update-external-docs.ymlmyself. This needs to be run to ensure that the script is copied over properly, and for the site contributing page to get populated.