Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#790 bump busboy up to solve encoding bug #1092

Closed
wants to merge 1 commit into from

Conversation

erano067
Copy link

busboy in package json version(^0.2.11 = 0.2.14) does not handle multi fields in content-disposition.
so i bump up the version and fix all minor api breaking changes of busboy.

@justinnitz
Copy link

A CVE is now associated with the dicer package. Upgrading to at least 1.0.0 of busboy removes dicer from multer's transitive dependency list.

mscdex/busboy#250
https://security.snyk.io/vuln/SNYK-JS-DICER-2311764

@mrded
Copy link

mrded commented May 23, 2022

Two problems here:

  1. The change is not formated: do ./node_modules/.bin/standard --fix
  2. The tests are failing: npm run test
  • Error Handling: should report errors from busboy parsing
  • Unicode: 2) should handle unicode filenames

@progsmile
Copy link

progsmile commented May 26, 2022

Two problems here:

What the version of node.js? I've reproduced it on node v10.

@RopoMen
Copy link

RopoMen commented Jun 2, 2022

@mrded unicode issue solution is in this PR #1102

@LinusU
Copy link
Member

LinusU commented Oct 30, 2022

This is done and discussed in #1097, currently it's published as 1.4.5-lts.1

@LinusU LinusU closed this Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants