Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: returns httpServer for e2e testing with supertest #20

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

rsaz
Copy link
Member

@rsaz rsaz commented Apr 26, 2024

Pull Request Guidelines

Our guidelines for submitting a pull request.

Before submitting a Pull Request, please make sure you have verified the following:

  • The commit message follows our guidelines:
    • A good commit message should be two things: meaningful and concise. It should not contain every single detail, describing each changed line—we can see all the changes in Git—but, at the same time, it should say enough to avoid ambiguity.
    • We use Microverse's commit message convention
    • The convention stablish that a commit message has to be in the present tense, imperative and lowercase.
    • Example: fix typo in README.md
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Please describe the current behavior that you are modifying, or link to a relevant issue.
No support for supertest e2e testing as the app express are not exposed

Issue Number: N/A

What is the new behavior?

Describe the new behavior or link to a relevant issue.

created a method called getHttpServer that returns a proxy to the app express limiting the function to only work with supertest

Does this PR introduce a breaking change?

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications below.

Other information

Any other information that is important to this PR.

@rsaz rsaz added the enhancement New feature or request label Apr 26, 2024
@rsaz rsaz self-assigned this Apr 26, 2024
@rsaz rsaz linked an issue Apr 26, 2024 that may be closed by this pull request
1 task
@rsaz rsaz merged commit c2b5009 into main Apr 26, 2024
5 checks passed
@rsaz rsaz deleted the 18-create-a-method-to-provide-an-interface-to-supertest branch April 26, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

Create a method to provide an interface to supertest
1 participant