Updates the schema version in theme.json files
#169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orballo
changed the title
theme.json filestheme.json files
orballo
changed the title
theme.json filestheme.json files
|
While migrating theme.json from v2 to v3, we also need to adjust properties to align with v3. Here are the required changes. Additional testing will be needed after these changes. |
|
I see. The linter didn't flag anything of that :/ I'll have a look at it next week, since this is low priority. |
|
Amjad is going to look into this instead of me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The linter is warning that the schema version should be
3, and when using the theme/styles internally, WordPress is already transforming the version from2to3after reading the files from disk.Solution
Updates the version in all the
theme.jsonfiles for theme and styles.