Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify TYPO3 v10 support in composer.json #2

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

EcoGabe
Copy link

@EcoGabe EcoGabe commented Jun 28, 2023

No description provided.

@opi99
Copy link
Contributor

opi99 commented Sep 26, 2023

Doesn't the BW compatibility break by removing the mixin?

Include form engine setup in module settings to allow saving the form
@EcoGabe
Copy link
Author

EcoGabe commented Sep 28, 2023

I've just been making my own instance compatible, I didn't intend to make more changes to this PR (else it should be renamed v11 support).

That being said... since mixins are just shortcuts for importing configuration from another file, shouldn't it still work with older versions of Typo3? I just replaced the mixin with the Yaml configuration the mixin contained/referred to. I would still be interested in upstream being compatible with the latest versions of Typo3, if that's a possibility.

@opi99
Copy link
Contributor

opi99 commented Oct 5, 2023

Yes and no, they are needed. IMHO you can leave the mixin line untouched for TYPO3 v10/v11 support

@EcoGabe
Copy link
Author

EcoGabe commented Oct 12, 2023

image
It would be nice if mixins did not require a definition. Unfortunately, leaving the mixin line untouched causes errors in v11 because it does not exist

@opi99
Copy link
Contributor

opi99 commented Oct 13, 2023

Uhhh, so, need to check another project, IMHO I leave it in. :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants