Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MVC - API, ViewBinding적용 #2

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from
Open

MVC - API, ViewBinding적용 #2

wants to merge 18 commits into from

Conversation

Leesin0222
Copy link
Member

@Leesin0222 Leesin0222 commented Dec 24, 2024

PR 작업 요약

2주차 과제 중 MVC패턴에 대해 구현해주었습니다. viewBinding과 api를 구현하고 직접 Spring boot를 사용하여 api를 구현하였습니다.

작업 내용

  • ViewBinding적용
    • 모든 화면에 ViewBinding을 적용해주었습니다.
  • api 호출 로직을 구현
    • 최근 읽은 카드 목록 받아오기 api
    • 모든 카드 목록 받아오기 api
    • 카드 읽음 상태 변경 api
  • Lifecycle, ToastMessage관련 확장 함수 구현.
  • 최근 읽은 카드 목록 받아오기 api를 구현하여 기존 최근 읽은 카드 list를 관리하는 RecentReadCardListManager를 제거해주었습니다.

Preview

ezyZip.1.mp4

추가 사항

  • M(Model) VC(Activity, Fragment)
  • imageUrl이 빈 String이기 때문에 이미지가 preview영상 내에서 비어있습니다.

@Leesin0222 Leesin0222 requested a review from f-lab-bot December 24, 2024 10:58
@Leesin0222 Leesin0222 self-assigned this Dec 24, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

@Leesin0222 Leesin0222 marked this pull request as draft December 24, 2024 10:59

private val json = Json {
ignoreUnknownKeys = true
coerceInputValues = true

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Leesin0222 Leesin0222 added the enhancement New feature or request label Dec 25, 2024
@Leesin0222 Leesin0222 marked this pull request as ready for review December 25, 2024 02:49
@Leesin0222 Leesin0222 changed the base branch from develop to main December 25, 2024 04:54
@Leesin0222 Leesin0222 changed the base branch from main to develop December 25, 2024 04:54
@Leesin0222 Leesin0222 changed the title MVC API, ViewBinding적용 Dec 25, 2024
@Leesin0222 Leesin0222 changed the title API, ViewBinding적용 MVC - API, ViewBinding적용 Dec 25, 2024
_binding = FragmentAllCardListBinding.inflate(inflater, container, false)
val view = binding.root
return view
}
Copy link

@theo-f-lab theo-f-lab Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

View = Fragment.inflate().also {
   _binding = it
}.root

View = Fragment.inflate().apply {
   _binding = this
}.root

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants