Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat][#2] 게임 클라이언트 구현 #17

Conversation

Stark-Industries0417
Copy link
Collaborator

@Stark-Industries0417 Stark-Industries0417 commented Jan 29, 2025

🔗관련 이슈

✨작업 내용

  • 간단한 게임 클라이언트 구현

⚠️참고 사항

  • js 파일에 기입할 웹소켓 공인 IP 주소는 슬랙 쓰레드에 기입해 두겠습니다

감사합니다

@Stark-Industries0417 Stark-Industries0417 self-assigned this Jan 29, 2025
@Stark-Industries0417 Stark-Industries0417 added ✅ s.completed 작업이 완료된 상태 ⚡ p.medium 일반적인 우선순위의 이슈 🚀 t.feature 새로운 기능 추가 labels Jan 29, 2025
Copy link

@f-lab-saponin f-lab-saponin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

간단한 게임 화면을 잘 구성했네요.
코멘트 드린 부분만 확인 부탁드립니다!

sendPlayerMoveRequest(direction);
}
renderScene();
requestAnimationFrame(gameLoop);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 메소드가 없는 것 같아요. 확인부탁드립니다 😀

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해당 메서드는 브라우저에 내장된 메서드 인데 혹시 어떤 환경에서 실행해보신걸까요?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 그렇군요 감사합니다 ㅎㅎ

Copy link

@f-lab-saponin f-lab-saponin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 👏👏

@Stark-Industries0417 Stark-Industries0417 merged commit 2acf925 into deploy/ncp-docker-setup Feb 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚡ p.medium 일반적인 우선순위의 이슈 ✅ s.completed 작업이 완료된 상태 🚀 t.feature 새로운 기능 추가
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants