Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tutorial.md and code from tutorial/ for new delorian.js #94

Merged
merged 3 commits into from
Mar 16, 2016

Conversation

andreip
Copy link
Contributor

@andreip andreip commented Nov 29, 2015

Description

Related to issue #90.

tutorial.md wasn't updated to the delorian.js version present in the cdn (it was updated from 0.8.3 where it was working accordingly). Also updated the code in examples/tutorial/ to match the new tutorial.md.

Another unsolved issue

Note that step 5 from the tutorial.md wasn't working correctly even with delorean-0.8.3 which is released around the same time the file was written (end of September 2014). You can try it out and see it's producing results like:

ITEM: ITEM: ITEM: ITEM: ITEM: 0.5519198384135962
ITEM: ITEM: ITEM: ITEM: 0.014080600813031197
ITEM: ITEM: ITEM: 0.8087677867151797
ITEM: ITEM: 0.9754587386269122
ITEM: 0.560909275431186

I just started looking over flux, so best I can do it point it out, don't know a good fix for it.

Get store directly from `DeLorean.Flux.createStore` and use `myStore.list.forEach` instead of `myStore.store.list.forEach`.
It's annoying to click on button and have it be moved by populating
list.
@f f closed this Mar 16, 2016
@f f reopened this Mar 16, 2016
f added a commit that referenced this pull request Mar 16, 2016
Update tutorial.md and code from tutorial/ for new delorian.js
@f f merged commit f0dc059 into f:master Mar 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants