main v1.1.3 fix

f5devcentral · May 24, 2023 · 144c480 · 144c480
1 parent 0122d0a
commit 144c480
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -20,6 +20,13 @@ Check [Keep a Changelog](http://keepachangelog.com/) for recommendations on how
 
 ---
 
+## [1.1.3] - (05.25.2023)
+
+### Changed
+
+- [BUG] more snatpool abstraction bug/tweaks
+- log error when app abstraction encounters error
+
 ## [1.1.2] - (05.25.2023)
 
 ### Changed

diff --git a/package.json b/package.json
@@ -2,7 +2,7 @@
   "name": "f5-corkscrew",
   "description": "extracting tmos config",
   "author": "F5DevCentral",
-  "version": "1.1.2",
+  "version": "1.1.3",
   "license": "Apache-2.0",
   "homepage": "https://github.com/f5devcentral/f5-corkscrew#readme",
   "main": "dist/index.js",

diff --git a/src/digConfigs.ts b/src/digConfigs.ts
@@ -39,10 +39,10 @@ export async function digVsConfig(vsName: string, vsConfig: BigipConfObj["ltm"][
     if (appObj.pool) {
         // dig pool details
         // just reassign the parsed pool details into the vs
-        const body = configTree.ltm.pool[vsConfig.pool];
+        const body = configTree.ltm?.pool?.[vsConfig.pool];
         appObj.lines.push(`ltm pool ${appObj.pool} {${body.line}}`);
         // raw copy the pool config
-        appObj.pool = JSON.parse(JSON.stringify(configTree.ltm.pool[vsConfig.pool]));
+        appObj.pool = JSON.parse(JSON.stringify(configTree.ltm?.pool?.[vsConfig.pool]));
         delete appObj.pool.line;
 
         if(appObj.pool?.members) {
@@ -103,7 +103,7 @@ export async function digVsConfig(vsName: string, vsConfig: BigipConfObj["ltm"][
 
         // if this snat string is the name of a snat pool, then replace with snatpool details
         //  if not, then its 'automap' or 'none' => nothing to add here
-        if (configTree.ltm.snatpool[vsConfig.snat]) {
+        if (configTree.ltm?.snatpool?.[vsConfig.snat]) {
             const c = JSON.parse(JSON.stringify(configTree.ltm.snatpool[vsConfig.snat]));
             appObj.lines.push(`ltm snatpool ${vsConfig.snat} { ${c.line} }`)
             delete c.line;

diff --git a/src/ltm.ts b/src/ltm.ts
@@ -456,7 +456,8 @@ export default class BigipConfig extends EventEmitter {
                         apps.push(vsApp);
                     })
                     .catch(err => {
-                        apps.push({ name: key, lines: err, });
+                        // apps.push({ name: key, lines: err, });
+                        logger.error(`corkscrew: problem abstracting app/vs ${key}`, err);
                     })
             }
 

diff --git a/tests/037_ltmDetails.tests.ts b/tests/037_ltmDetails.tests.ts
@@ -91,6 +91,16 @@ describe('LTM parsing/abstraction', async function () {
 
     });
 
+    it(`no snat pools`, async function () {
+
+        delete device.configObject.ltm?.snatpool;
+
+        const localExpld = await device.explode();
+
+        assert.ok(localExpld, 'should not error while abstracting apps with missing configs');
+
+    });
+