Wait until gReadyState == 'complete' before triggering firing onready #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gReadyState == 'interactive' is before all external localization files are loaded. The localization event itself is also triggered right when gReadyState == 'complete'.
With this change, it is possible to have readyState transitions loading -> interactive -> complete -> interactive -> complete instead of loading -> interactive -> complete. This change allows the document.webL10n.ready(callback) method to wait until all l10n files have been loaded when loadLocale is called again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gReadyState == 'interactive' is before all external localization files are loaded. The localization event itself is also triggered right when gReadyState == 'complete'. So we have to wait until gReadyState == 'complete' before calling the callback.
Fixes #64 (comment) (@paulguz)