Change email regex to a handcrafted one #180

fabian-hiller · Oct 7, 2023 · 8ad42e7 · 8ad42e7
1 parent 8bf2e93
commit 8ad42e7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/library/src/validations/email/email.test.ts b/library/src/validations/email/email.test.ts
@@ -43,6 +43,7 @@ describe('email', () => {
     expect(validate('[email protected] (Joe Smith)').issues).toBeTruthy();
     expect(validate('email@example').issues).toBeTruthy();
     expect(validate('[email protected]').issues).toBeTruthy();
+    expect(validate('[email protected]').issues).toBeTruthy();
     expect(validate('[email protected]').issues).toBeTruthy();
     expect(validate('[email protected]').issues).toBeTruthy();
     expect(validate('[email protected]').issues).toBeTruthy();

diff --git a/library/src/validations/email/email.ts b/library/src/validations/email/email.ts
@@ -10,7 +10,7 @@ import { getOutput, getPipeIssues } from '../../utils/index.ts';
  */
 export function email<TInput extends string>(error?: ErrorMessage) {
   return (input: TInput): PipeResult<TInput> =>
-    !/^(?!\.)(?!.*\.\.)([A-Z0-9_+-.]*)[A-Z0-9_+-]@([A-Z0-9][A-Z0-9-]*\.)+[A-Z]{2,}$/i.test(
+    !/^[\w+-]+(?:\.[\w+-]+)*@[A-Z0-9]+(?:(?:\.|-)[A-Z0-9]+)*\.[A-Z]{2,}$/i.test(
       input
     )
       ? getPipeIssues('email', error || 'Invalid email', input)