Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add checkItemsAsync action #856

Merged

Conversation

EltonLobo07
Copy link
Contributor

No description provided.

@EltonLobo07 EltonLobo07 changed the base branch from main to v1-beta September 28, 2024 20:21
@EltonLobo07 EltonLobo07 changed the title Feat/add check items async add checkItemsAsync action Sep 28, 2024
Copy link

pkg-pr-new bot commented Sep 28, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/valibot@856

commit: 0e1a15c

@EltonLobo07
Copy link
Contributor Author

EltonLobo07 commented Sep 28, 2024

Once I add the updated API references on the website (I'll do that tomorrow), you can review and merge this PR. 

Since there is an async version of the action, the
action should return a `MaybePromise` type just
like other actions that have an async version.
@EltonLobo07
Copy link
Contributor Author

All changes done, you can review the PR!

@fabian-hiller fabian-hiller self-assigned this Oct 10, 2024
@fabian-hiller fabian-hiller added the enhancement New feature or request label Oct 10, 2024
@fabian-hiller fabian-hiller changed the base branch from v1-beta to main October 10, 2024 20:58
@fabian-hiller fabian-hiller merged commit c25643c into fabian-hiller:main Oct 10, 2024
11 checks passed
@fabian-hiller
Copy link
Owner

v1.0.0-beta.1 with the checkItemsAsync action is available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants