Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed List type #2127

Merged
merged 1 commit into from
Jul 27, 2020
Merged

Conversation

ncave
Copy link
Collaborator

@ncave ncave commented Jul 22, 2020

@alfonsogarciacaro

  • I fixed the List type with real tail (as opposed to copy tail), it works now. You can merge it in the optimized-list branch.
  • Unfortunately there is no perf improvement vs the copy-tail version (still about 17% slower than the original), so the bottle-neck must be somewhere else. But it should in theory help with the memory usage.
  • There is still room for improvement, like making the Head/Tail/Length/IsEmpty/Item iterative instead of recursive, and other optimization attempts that can continue in [WIP] Optimized List module #2124.

@gitpod-io
Copy link

gitpod-io bot commented Jul 22, 2020

@alfonsogarciacaro alfonsogarciacaro merged commit c191f31 into fable-compiler:optimized-list Jul 27, 2020
@ncave ncave deleted the work3 branch September 12, 2020 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants