Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case: we had a previously monolingual application with a model with lots of attributes, presented in a specific order on the admin page. Adding translations, usage of
activeadmin-globalize
would have required to move all translation fields to a single section on the page, breaking earlier order. We wanted to have non-consecutive translated inputs, but it turned out that adding multipletranslated_input
s resulted in trying to add multiple translation records per locale.This patch makes the field names use keys generated from the locale, rather than the default incrementing integers. This way, even when multiple translation blocks are added, the same key ensures that the POSTed data is interpreted correctly by the server. Most of the changes were actually to the JS side: locale tab rendering and on-submit data filtering.