Skip to content

Commit

Permalink
fix(pypi): Generate dependency graph only if pip install completes wi…
Browse files Browse the repository at this point in the history
…thout error (#333)

This fix mitigates generating incomplete stack report., and behaviour of pypi will match with the other ecosystems(maven & npm).

This PR fixes issue #327.
  • Loading branch information
arajkumar authored Aug 21, 2019
1 parent 13d4cf2 commit 6ee7b7f
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions src/ProjectDataProvider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -286,12 +286,13 @@ export module ProjectDataProvider {
}
const cmd: string = [
pyPiInterpreter,
`-m pip install -r `,
` ${reqTxtFilePath};`,
`-m pip install -r`,
reqTxtFilePath,
`&&`,
pyPiInterpreter,
StatusMessages.PYPI_INTERPRETOR_CMD,
` ${reqTxtFilePath}`,
` ${filepath}`
reqTxtFilePath,
filepath
].join(' ');
console.log('CMD : ' + cmd);
outputChannelDep.addMsgOutputChannel('\n CMD :' + cmd);
Expand Down

0 comments on commit 6ee7b7f

Please sign in to comment.