Fixes various issues. #13, #14, #17 and partially #15 #20
Conversation
…more, and reordered params for readability
openshift/launchpad-template.yaml
Outdated
| @@ -41,11 +41,13 @@ parameters: | |||
| - description: OpenShift user name (leave empty when using Keycloak) | |||
| displayName: OpenShift user name | |||
| name: LAUNCHPAD_MISSIONCONTROL_OPENSHIFT_USERNAME | |||
| value: developer | |||
| value: | |||
| required: true | |||
There was a problem hiding this comment.
I don't think this is correct. A) because the username and password can be left empty if we want to use a token and B) the "developer/developer" is a correct default value. Right @gastaldi ?
There was a problem hiding this comment.
I just read your explanation for this on the mailing list @jorgemoralespou . I understand using default username/password in a template is not best practice, but I'm not sure if ease-of-use is more important here or not ( @ALRubinger ? ). They still need to be optional though.
openshift/launchpad-template.yaml
Outdated
| - description: OpenShift password (leave empty when using Keycloak) | ||
| displayName: OpenShift password | ||
| name: LAUNCHPAD_MISSIONCONTROL_OPENSHIFT_PASSWORD | ||
| value: developer | ||
| value: | ||
| required: true |
| displayName: OpenShift user name | ||
| description: OpenShift user name (leave empty when using Keycloak) | ||
| value: | ||
| required: true |
There was a problem hiding this comment.
This is not supposed to be required
There was a problem hiding this comment.
The template will help Minishift users to get started quickly, so I guess it makes sense to have developer as the default value for the user and password
| displayName: OpenShift password | ||
| description: OpenShift password (leave empty when using Keycloak) | ||
| value: | ||
| required: true |
|
Ok, merged a clean-up version of this manually. Closing. Thanks Jorge! |
@gastaldi There's still need to fix versioning, when #16 can be totally understood, and fix #15 to include tags for the images being provided once the release process is correctly known.