WIP: update event system #2189
WIP: update event system #2189
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2189 +/- ##
==========================================
- Coverage 69.84% 69.39% -0.46%
==========================================
Files 170 170
Lines 15826 15778 -48
==========================================
- Hits 11054 10949 -105
- Misses 3760 3802 +42
- Partials 1012 1027 +15
Continue to review full report at Codecov.
|
|
[test] |
| "relationships": { | ||
| "modifier": { | ||
| "data": { | ||
| "id": "00000000-0000-0000-0000-000000000002", | ||
| "links": { | ||
| "related": "http:///api/users/00000000-0000-0000-0000-000000000002" |
There was a problem hiding this comment.
Please note that JSONAPI doesn't allow both to be specified: type+id and links. Instead only one is allowed.
| "oldValue": null, | ||
| "timestamp": "0001-01-01T00:00:00Z" | ||
| "timestamp": "0001-01-01T00:00:00Z", | ||
| "workItemTypeID": "00000000-0000-0000-0000-000000000001" |
There was a problem hiding this comment.
Note, that an event needs to know about the work item type at the given point int type. This is important so that the UI can find out how to resolve the name (e.g. system.description) into a field.
There was a problem hiding this comment.
I think I should make this a relationships really. Let me do that.
|
Closing in favor of https://github.com/fabric8-services/fabric8-wit/tree/kwk_event_cleanup branch. |
There were places inside of the event system that dealt with work item fields by name and not by their type. Here's what's done by this change.
workitem.SimpleTypeandworkitem.EnumType) and multi-value (workitem.ListType) fields in the work item repository.workitem.FieldType.ConvertFromModelfunction to convert stored values from the DB into the model space. Previously this was done manually and everything was converted to a string.controller/test-files/event/list/ok-kindFloat.res.payload.golden.jsonandcontroller/test-files/event/list/ok-kindInt.res.payload.golden.jsonfiles to see that effect.