Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: SourceMojo: Use isEmpty() to check whether collection is empty or not issue1746 #1747

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

mdxabu
Copy link
Contributor

@mdxabu mdxabu commented Feb 4, 2024

Hello Maintainers,

I just wanted to let you know that I have modified the code. I have changed the imageConfigs>0 to !imageConfigs.isEmpty() to check whether the Collection is empty. After making these changes, I have used the mvn clean install command.

Best Regards,
@mdxabu

Copy link

sonarqubecloud bot commented Feb 4, 2024

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Merging #1747 (ecddc06) into master (e8207b9) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1747   +/-   ##
=========================================
  Coverage     65.33%   65.33%           
  Complexity     2284     2284           
=========================================
  Files           172      172           
  Lines         10191    10191           
  Branches       1408     1408           
=========================================
  Hits           6658     6658           
  Misses         2983     2983           
  Partials        550      550           
Files Coverage Δ
.../main/java/io/fabric8/maven/docker/SourceMojo.java 0.00% <0.00%> (ø)

@mdxabu
Copy link
Contributor Author

mdxabu commented Feb 4, 2024

codecov ,I think the checks failed because it was a small change.

@rohanKanojia rohanKanojia merged commit 68d31d0 into fabric8io:master Feb 4, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants